fix: add logging to silent catch blocks#24331
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one related PR: Potential Related PR:
However, since PR #24331 is the current PR and it appears to have broader scope (across 10 production files with ~30 catch blocks vs. cleanup operations), this is likely a separate, complementary effort rather than a true duplicate. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
8a85782 to
eb8bd1e
Compare
Add logging to selected silent catch blocks in auth, MCP cleanup, provider error parsing, PTY teardown, mDNS cleanup, session error handling, and utility helpers. Replace one catch (e: any) with unknown-safe handling in session/llm.ts. Closes anomalyco#24327
eb8bd1e to
44a01d5
Compare
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #24327
Type of change
What does this PR do?
Adds logging to selected silent catch blocks where failures were being swallowed without any signal:
It also replaces one
catch (e: any)insession/llm.tswithunknownhandling.How did you verify your code works?
origin/devgit diff --check origin/dev..HEADI tried
cd packages/opencode && bun typecheckinside the temporary worktree, but that worktree does not have the repo dependencies installed, so TypeScript reported dependency resolution errors before checking this patch.Checklist